-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename avoidance package #7168
Merged
satoshi-ota
merged 8 commits into
autowarefoundation:main
from
tier4:chore/rename-avoidance-package
May 31, 2024
Merged
chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename avoidance package #7168
satoshi-ota
merged 8 commits into
autowarefoundation:main
from
tier4:chore/rename-avoidance-package
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
May 30, 2024
satoshi-ota
force-pushed
the
chore/rename-avoidance-package
branch
from
May 30, 2024 05:35
4aa8306
to
4aeb75e
Compare
satoshi-ota
requested review from
rej55,
kyoichi-sugahara,
taikitanaka3,
danielsanchezaran,
go-sakayori,
kosuke55,
soblin,
maxime-clem,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4,
TomohitoAndo,
yuki-takagi-66 and
mkuri
as code owners
May 30, 2024 10:23
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 30, 2024
yuki-takagi-66
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much
LGTM
Perhaps the parameter file name should be changed as well, but I don't mind either way.
...autoware_behavior_path_dynamic_obstacle_avoidance_module/config/dynamic_avoidance.param.yaml
Outdated
Show resolved
Hide resolved
…e package and namespace Signed-off-by: satoshi-ota <[email protected]>
…me package and namespace Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
chore/rename-avoidance-package
branch
from
May 30, 2024 13:21
67d2794
to
ec309e9
Compare
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
rej55
approved these changes
May 31, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…avoidance package (autowarefoundation#7168) * chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(tier4_planning_launch): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(rtc_interface): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update module param file name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update schema file name Signed-off-by: satoshi-ota <[email protected]> * fix(AbLC): fix file name Signed-off-by: satoshi-ota <[email protected]> * docs: update module name Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…avoidance package (autowarefoundation#7168) * chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(tier4_planning_launch): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(rtc_interface): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update module param file name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update schema file name Signed-off-by: satoshi-ota <[email protected]> * fix(AbLC): fix file name Signed-off-by: satoshi-ota <[email protected]> * docs: update module name Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…avoidance package (autowarefoundation#7168) * chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(tier4_planning_launch): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(rtc_interface): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update module param file name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update schema file name Signed-off-by: satoshi-ota <[email protected]> * fix(AbLC): fix file name Signed-off-by: satoshi-ota <[email protected]> * docs: update module name Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
7 tasks
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…avoidance package (#7168) * chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace Signed-off-by: satoshi-ota <[email protected]> * chore(tier4_planning_launch): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(rtc_interface): update module name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update module param file name Signed-off-by: satoshi-ota <[email protected]> * chore(avoidance): update schema file name Signed-off-by: satoshi-ota <[email protected]> * fix(AbLC): fix file name Signed-off-by: satoshi-ota <[email protected]> * docs: update module name Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename modules:
behavior_path_avoidance_module
->autoware_behavior_path_static_obstacle_avoidance_module
behavior_path_dynamic_avoidance_module
->autoware_behavior_path_dynamic_obstacle_avoidance_module
Tests performed
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.